Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If issuing a restart or updating an image, do that first before applying anything else. #698

Merged
merged 5 commits into from
Apr 9, 2024

Conversation

nhudson
Copy link
Collaborator

@nhudson nhudson commented Apr 8, 2024

This code change add handling if a restart is issued or if an image update is issued in the case where multiple values are being updated.

For example if you issue a restart whist also updating another value in CoreDB, this will make sure that the restart is done first before doing anything else. Also if you are updating the image it will apply the image update first before doing anything else. It should negate seeing this error in the controller logs

2024-02-16T14:31:37.145986Z ERROR reconciling object:reconcile:reconcile:reconcile_cnpg: controller::cloudnativepg::cnpg:1079: Error patching cluster: ApiError: admission webhook "vcluster.cnpg.io" denied the request: Cluster.cluster.cnpg.io "org-v0idpwn-industries-inst-smol-tri" is invalid: spec.imageName: Invalid value: "387894460527.dkr.ecr.us-east-1.amazonaws.com/tembo-io/standard-cnpg:15-a0a5ab5": Can't change image name and configuration at the same time. There are differences in PostgreSQL configuration parameters: {"effective_io_concurrency":["","100"]}: Invalid (ErrorResponse { status: "Failure", message: "admission webhook \"vcluster.cnpg.io\" denied the request: Cluster.cluster.cnpg.io \"org-v0idpwn-industries-inst-smol-tri\" is invalid: spec.imageName: Invalid value: \"387894460527.dkr.ecr.us-east-1.amazonaws.com/tembo-io/standard-cnpg:15-a0a5ab5\": Can't change image name and configuration at the same time. There are differences in PostgreSQL configuration parameters: {\"effective_io_concurrency\":[\"\",\"100\"]}", reason: "Invalid", code: 422 }) object.ref=CoreDB.v1alpha1.coredb.io/org-v0idpwn-industries-inst-smol-tri.org-v0idpwn-industries-inst-smol-tri object.reason=reconciler requested retry trace_id=00000000000000000000000000000000 instance_name=org-v0idpwn-industries-inst-smol-tri

Fixes: PLAT-539 & PLAT-77

@nhudson nhudson merged commit bbb4648 into main Apr 9, 2024
9 checks passed
@nhudson nhudson deleted the nhudson/PLAT-539 branch April 9, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants