Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Remove Postgres password from path #701

Merged
merged 6 commits into from
Apr 10, 2024
Merged

Fix: Remove Postgres password from path #701

merged 6 commits into from
Apr 10, 2024

Conversation

joshuajerin
Copy link
Contributor

No description provided.

@joshuajerin joshuajerin marked this pull request as ready for review April 9, 2024 16:05
sjmiller609
sjmiller609 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@sjmiller609 sjmiller609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing is making sure only the 3 secret names are allowed "app-role", "readonly-role", and "superuser-role"

@sjmiller609 sjmiller609 merged commit 57c5aec into main Apr 10, 2024
3 checks passed
@sjmiller609 sjmiller609 deleted the dp-updatepassword_fix branch April 10, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjmiller609 sjmiller609 sjmiller609 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshuajerin @sjmiller609