Generate CoreDB Spec from Stack Spec #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChuckHend
requested review from
jasonmp85,
sjmiller609,
nhudson and
ianstanton
as code owners
jasonmp85
reviewed
May 8, 2024
| metadata: serde_json::json!({ | ||
| "name": resource_name, | ||
| }), | ||
| spec: spec.clone(), |
There was a problem hiding this comment.
It's a short-lived CLI tool, so it probably doesn't matter, but I'm trying to practice with the borrow checker and think it would be pretty easy to just pass ownership of spec to this function at the point of calling it, right? It's never used again in the calling function.
That said, it won't affect correctness or performance to use clone, I'm just reading to learn Rust better.
jasonmp85
reviewed
May 8, 2024
| @@ -175,6 +214,20 @@ fn default_storage() -> String { | |||
| "10Gi".to_owned() | |||
| } | |||
|
|
|||
| pub fn merge_options<T>(opt1: Option<Vec<T>>, opt2: Option<Vec<T>>) -> Option<Vec<T>> | |||
There was a problem hiding this comment.
Unless I missed something, this isn't called in the changes in this review, right? What's it for?
jasonmp85
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick way to generate a CoreDB Spec from a Stack spec. This wont work for all cases, and definitely not for production usage but will be handy for local development.