Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COR-175] Image build and upload #79

Merged
merged 47 commits into from
Feb 4, 2023
Merged

[COR-175] Image build and upload #79

merged 47 commits into from
Feb 4, 2023

Conversation

sjmiller609
Copy link
Contributor

@sjmiller609 sjmiller609 commented Feb 4, 2023

This is the plan for our release automation:

Image workflow (on commit to any branch): This PR is only handling this part

  • Publish docker image with git hash as tag
  • If main or release/** branch, also publish the version in cargo.toml, if the file is present
  • If main branch, also publish ‘latest’

Below items in following PRs

Cargo workflow (on commit to main or release/** branch):

  • publish cargo projects that are not already published (i.e. skip publish when version in Cargo.toml already exists on crates.io)

Github release workflow (on commit to release/** branch):

  • github release for the major.minor version in the branch name, lowest unused patch number
  • in release note, list versions of subcomponents

On PR to main or release/** branch:

  • For changes in Cargo projects, fail if the version in Cargo.toml is already is published

Comment on lines +25 to +28
calver_suffix:
description: 'Optional suffix to the calendar version'
required: false
default: ""
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did not end up consuming this feature in a workflow, but might as well leave it in case we want this flag later.

@sjmiller609 sjmiller609 changed the title work in progress, working on release automation [COR-175] Image build and upload Feb 4, 2023
Comment on lines +19 to +20
- name: Find directories with Dockerfiles
id: find_directories
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step finds directories with Dockerfiles, filtering for only those that are changed. In the case of main branch or release branch, it provides all directories with a Dockerfile. In following PR, want to move this into an action and also reuse the logic for Cargo.toml files in order to take action only when a particular crate changed.

@@ -1,26 +0,0 @@
name: CoreDB operator image build and upload
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change consolidates all image build workflows.

@sjmiller609 sjmiller609 marked this pull request as ready for review February 4, 2023 02:57
@sjmiller609 sjmiller609 merged commit e111577 into main Feb 4, 2023
@sjmiller609 sjmiller609 deleted the cor-175/0.1 branch February 4, 2023 14:07
sjmiller609 added a commit that referenced this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants