-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COR-175] Image build and upload #79
Conversation
calver_suffix: | ||
description: 'Optional suffix to the calendar version' | ||
required: false | ||
default: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did not end up consuming this feature in a workflow, but might as well leave it in case we want this flag later.
- name: Find directories with Dockerfiles | ||
id: find_directories |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This step finds directories with Dockerfiles, filtering for only those that are changed. In the case of main branch or release branch, it provides all directories with a Dockerfile. In following PR, want to move this into an action and also reuse the logic for Cargo.toml files in order to take action only when a particular crate changed.
@@ -1,26 +0,0 @@ | |||
name: CoreDB operator image build and upload |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change consolidates all image build workflows.
This is the plan for our release automation:
Image workflow (on commit to any branch): This PR is only handling this part
Below items in following PRs
Cargo workflow (on commit to main or release/** branch):
Github release workflow (on commit to release/** branch):
On PR to main or release/** branch: