add archive + destroy queue #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChuckHend
requested review from
ryw,
ianstanton and
sjmiller609
as code owners
sjmiller609
approved these changes
Feb 4, 2023
sjmiller609
pushed a commit
that referenced
this pull request
Dec 5, 2023
* add extension module * update traits * requeue when requested extensions are not synchronized * add retry policy on test * ext plan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.archive()method. This essentially moves the message from the queue table to the archive table, instead of outright deleting it..destroy()method. This deletes the queue table and its index, archive table, and deletes the queue record frompgmq_metatable. It might be safer for this to live in an "admin" API long term, instead of the "Queue" API. However, right now there is no admin API 😸and adds tests for both of these