Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC 7234] Cache entry freshness #513

Closed
krizhanovsky opened this issue May 25, 2016 · 1 comment
Closed

[RFC 7234] Cache entry freshness #513

krizhanovsky opened this issue May 25, 2016 · 1 comment
Assignees
@keshonok
Labels
crucial enhancement
Milestone
0.5 alpha

Comments

@krizhanovsky
Copy link
Contributor

krizhanovsky commented May 25, 2016 •
edited
Loading

RFC 7234 4.2 defines a cache entry freshness calculation. This must be generic function which can be called at request service time as well as in cache eviction thread.

The issue depends on #507 (Date is required header), #1 (we must generate warnings if heuristic freshness is used).

Depends on #523 in that response max-age must be accounted.

This should generate 113'th warning (#1), mark this as TODO.
@krizhanovsky krizhanovsky added this to the 0.5.0 Web Server milestone May 25, 2016
This was referenced May 25, 2016
Closed
Open
This was referenced May 26, 2016
Closed
Closed
keshonok added a commit that referenced this issue Jun 14, 2016
@keshonok
Calculate cache entry freshness (#513)
69d1f73 
- Add processing of max-stale and min-fresh CC directives;
- Handle overflows of CC directive's values according to RFC;
- Handle duplicates of CC directives and headers according to RFC;
- Calculate cache entry lifetime and store it in the cache entry;
- Store req/resp timestamps in a cache entry for age calculation;
- Calculate cache entry freshness. Consider request's max-age,
  max-stale, and min-fresh for cache entry freshness calculation;
- Return only fresh responses to requests from cache.
keshonok added a commit that referenced this issue Jun 14, 2016
@keshonok
Calculate cache entry freshness (#513)
3666f6f 
- Add processing of max-stale and min-fresh CC directives;
- Handle overflows of CC directive's values according to RFC;
- Handle duplicates of CC directives and headers according to RFC;
- Calculate cache entry lifetime and store it in the cache entry;
- Store req/resp timestamps in a cache entry for age calculation;
- Calculate cache entry freshness. Consider request's max-age,
  max-stale, and min-fresh for cache entry freshness calculation;
- Return only fresh responses to requests from cache.
keshonok added a commit that referenced this issue Jun 20, 2016
@keshonok
Address issues raised in code reviews.
59573f1 
Also, rework cache entry freshness calculation.
Related to #525, #507, #513, #523, #493, #416.
keshonok added a commit that referenced this issue Jun 20, 2016
@keshonok
Address issues raised in code reviews.
c2c62db 
Also, rework cache entry freshness calculation.
Related to #525, #507, #513, #523, #493, #416.
keshonok added a commit that referenced this issue Jun 20, 2016
@keshonok
Calculate cache entry freshness (#513)
56fe381 
- Add processing of max-stale and min-fresh CC directives;
- Handle overflows of CC directive's values according to RFC;
- Handle duplicates of CC directives and headers according to RFC;
- Calculate cache entry lifetime and store it in the cache entry;
- Store req/resp timestamps in a cache entry for age calculation;
- Calculate cache entry freshness. Consider request's max-age,
  max-stale, and min-fresh for cache entry freshness calculation;
- Return only fresh responses to requests from cache.
keshonok added a commit that referenced this issue Jun 20, 2016
@keshonok
Address issues raised in code reviews.
9ae6427 
Also, rework cache entry freshness calculation.
Related to #525, #507, #513, #523, #493, #416.
@keshonok
Copy link
Contributor

Implemented in #559.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keshonok keshonok

Labels
crucial enhancement
Projects
None yet
Milestone
0.5 alpha
Development

No branches or pull requests
2 participants
@krizhanovsky @keshonok