HTTP/2 Parser implementation (#309). #1368

aleksostapenko · 2019-10-26T16:20:03Z

No description provided.

krizhanovsky

This is just an intermediate review - a lot of things unfinished and not fixed since #1338 . Also I didn't dive too deeply into the code though.

tempesta_fw/hpack.c

tempesta_fw/cache.c

tempesta_fw/http_frame.c

tempesta_fw/http_parser.c

tempesta_fw/hpack.c

tempesta_fw/http_msg.c

tempesta_fw/hpack.c

tempesta_fw/http.c

1. Changes in HPACK decoder to copy only Huffman-decoded and dynamically indexed headers; 2. Appropriate changes in HPACK-decoder/parser unit-tests.

…lity (#309).

…O' comments (#309).

Corrections as a result of HPACK decoder/encoder/parser unit-tests debugging.

…tion flow (#309).

krizhanovsky

I'm still in progress for the review. Besides not fixed issues from my previous PR and this PR, there are new issues with the new code which must be fixed.

tempesta_fw/http_parser.c

tempesta_fw/hpack.h

tempesta_fw/http_msg.c

tempesta_fw/http.c

tempesta_fw/http_parser.c

tempesta_fw/http.c

tempesta_fw/http_msg.c

tempesta_fw/http.c

…lts (#309).

…tion (#309).

krizhanovsky

I completely dislike the multiple HTTP header strings processing.

tempesta_fw/http_msg.h

tempesta_fw/http_msg.c

krizhanovsky · 2019-11-23T22:17:43Z

While HTTP/2 usage is still less than HTTP/1.1, it actually means that site owners don't deploy HTTP/2 and just stay on current (old) configurations. Meantime, it seems the most modern web clients do support HTTP/2, so

it's safe to make proto attribute of listen option h2 by default. Please patch etc/tempesta_fw.conf and adjust the Wiki
basically there is no sense to care about HTTP/1 performance on client side (only backend side matters for compatibility with the legacy backends).

TfwStrs often go in arrays, and there is a 1-byte alignment gap between TfwStr neighbours. `eolen` is always [0,2], 14-bits are enough for hpack index.

# Conflicts: # tempesta_fw/http_parser.c # tempesta_fw/http_sess.c # tempesta_fw/t/unit/test_hpack.c # tempesta_fw/t/unit/test_http_sticky.c

krizhanovsky

More notes to make the HTTP/2 parser faster, required for #1207.

tempesta_fw/http_parser.c

…ve duplication conflicts

…renct additions of CRLF

… is broken

Don't switch fsm state on processing frame header, update the fsm state only after the full frame is processed. Otherwise the fsm is triggered twice and fsm closes the connection when a new fragment of frame is expected.

Fix request h2 -> http1.1 conversion

Parse name, colon, LWS, value and RWS of HTTP/1.1-response headers into separate chunks to facilitate the name/value splitting and colon/OWS eviction during HTTP/1.1=>HTTP/2 response transformation.

…309).

A few review comment fixes for http2 parser

…om cache (#309).

…ion-h2-cache HTTP/2 implementation: HTTP/2-cache (#309).

@krizhanovsky

@krizhanovsky is out for conference and the PR should be merged before the conference

vankoven

Looks good to me. Any new issues found in the PR or caused by the PR will be fixed in separate PRs

HTTP/2 Parser implementation (#309).

71d7b7a

krizhanovsky reviewed Oct 28, 2019

View reviewed changes

aleksostapenko added 6 commits October 30, 2019 17:42

HTTP/2 Parser implementation (#309):

dc71702

1. Changes in HPACK decoder to copy only Huffman-decoded and dynamically indexed headers; 2. Appropriate changes in HPACK-decoder/parser unit-tests.

HTTP/2 Parser implementation: some comments added for HPACK functiona…

b5658be

…lity (#309).

HTTP/2 Parser implementation: numerous corrections and cleanups (#309).

9a57b1f

HTTP/2 Parser implementation: removal of outdated (already done) 'TOD…

8f9a906

…O' comments (#309).

HTTP/2 Parser implementation (#309):

fb7c80f

Corrections as a result of HPACK decoder/encoder/parser unit-tests debugging.

HTTP/2 Parser implementation: redesign of HTTP/1.1=>HTTP/2 transforma…

e50d74d

…tion flow (#309).

krizhanovsky requested changes Nov 21, 2019

View reviewed changes

aleksostapenko added 2 commits November 22, 2019 01:23

HTTP/2 Parser implementation: corrections according to debugging resu…

c935484

…lts (#309).

HTTP/2 Parser implementation: corrections in internal response genera…

f2e01bd

…tion (#309).

krizhanovsky requested changes Nov 22, 2019

View reviewed changes

tempesta_fw/http_msg.h Outdated Show resolved Hide resolved

tempesta_fw/http_msg.c Show resolved Hide resolved

tempesta_fw/http_msg.c Outdated Show resolved Hide resolved

vankoven added 9 commits December 4, 2019 19:00

bump copyrights

c692adb

Divide TfwStr flags and HPACK index members

dae477a

TfwStrs often go in arrays, and there is a 1-byte alignment gap between TfwStr neighbours. `eolen` is always [0,2], 14-bits are enough for hpack index.

Fix compile-time issues with 'stack frame non-standard' warnings

8849e87

Update code comments

ae7ce40

Update Linux kernel patch

e9bf486

Remove unneeded ss_skb_data() function

e8b1f87

Minor style fixups

266581d

Generate HPACK header on compiletime

45c9eba

Merge branch 'master' into ik-1369-merge-master

7b1cce0

# Conflicts: # tempesta_fw/http_parser.c # tempesta_fw/http_sess.c # tempesta_fw/t/unit/test_hpack.c # tempesta_fw/t/unit/test_http_sticky.c

krizhanovsky previously requested changes Dec 7, 2019

View reviewed changes

krizhanovsky mentioned this pull request Dec 7, 2019

HTTP parser adoption #1207

Closed

2 tasks

vankoven and others added 6 commits December 17, 2019 18:46

Resolve merge issues

fd48c6e

Fail test if parsed string was composed incorrectly, don't crash

80d2d4a

port changes from avb-1202 to http2

b1e6a11

Set-cookie was added in two branches with different processing, resol…

0620349

…ve duplication conflicts

Add HPACK generator and generated file

d4c682d

Fix some small comments

c67a387

vankoven and others added 13 commits January 11, 2020 02:21

h2: content-length is extra header, don't block messages if it's absent

2ad4c3f

h2: close connection if remote sends too huge frames

2b69ff4

Fix null pointer dereference on modifications on h1 headers and incor…

e6b400d

…renct additions of CRLF

h2: check settings before apply them. Reject if limits defined in RFC…

e257d63

… is broken

Add issue number for TODOs

ee0dced

Update macro documentations

6849d75

h2: Add several TODO comments

3cb5ec0

h2: fix too early fsm update for CONTINUATION frames

f91139f

Don't switch fsm state on processing frame header, update the fsm state only after the full frame is processed. Otherwise the fsm is triggered twice and fsm closes the connection when a new fragment of frame is expected.

h2: Improve check for mandatory pseudo headers presense

e7bd235

Fix code review comments

c114bed

Merge pull request #1374 from tempesta-tech/ik-fix-req-2-to-1-transform

f010557

Fix request h2 -> http1.1 conversion

HTTP/2 Parser implementation: HTTP/2-cache (#309).

c721aaa

HTTP/2: changes in processing of headers strings (#309).

4dec0e8

Parse name, colon, LWS, value and RWS of HTTP/1.1-response headers into separate chunks to facilitate the name/value splitting and colon/OWS eviction during HTTP/1.1=>HTTP/2 response transformation.

krizhanovsky mentioned this pull request Feb 27, 2020

Optimizer for HTTP messages adjustment #1103

Open

aleksostapenko and others added 10 commits March 1, 2020 01:30

HTTP/2: fix duplicate headers processing during response forwarding (#…

2d7bb75

…309).

HTTP/2: add header name tracking into the headers' compare procedure (#…

b5e71ac

…309).

HTTP/2: corrections according review comments (#309).

4f0cdd1

h2 parser: reduce number of compare operators during headers parsing

bb502ae

If listening for http/1.1 mode print performance warning

2585ef9

Bump copyrights

a841f0b

Merge pull request #1385 from tempesta-tech/ik-h2-parser-updates

5b7ecb5

A few review comment fixes for http2 parser

HTTP/2: evict redundant space during response status-line creation fr…

4f43032

…om cache (#309).

HTTP/2: corrections according additional review comments (#309).

6164968

Merge pull request #1383 from tempesta-tech/ao-309-parser-transformat…

7b4fc72

…ion-h2-cache HTTP/2 implementation: HTTP/2-cache (#309).

vankoven approved these changes Mar 5, 2020

View reviewed changes

aleksostapenko merged commit 8d90875 into master Mar 5, 2020

aleksostapenko deleted the ao-309-parser-transformation branch March 5, 2020 12:27

This was referenced Mar 5, 2020

Treat s_line as a singular header with index 0 #487

Closed

HTTP/2 #309

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HTTP/2 Parser implementation (#309). #1368

HTTP/2 Parser implementation (#309). #1368

aleksostapenko commented Oct 26, 2019

krizhanovsky left a comment

krizhanovsky left a comment

krizhanovsky left a comment

krizhanovsky commented Nov 23, 2019

krizhanovsky left a comment

vankoven left a comment

HTTP/2 Parser implementation (#309). #1368

HTTP/2 Parser implementation (#309). #1368

Conversation

aleksostapenko commented Oct 26, 2019

krizhanovsky left a comment

Choose a reason for hiding this comment

krizhanovsky left a comment

Choose a reason for hiding this comment

krizhanovsky left a comment

Choose a reason for hiding this comment

krizhanovsky commented Nov 23, 2019

krizhanovsky left a comment

Choose a reason for hiding this comment

vankoven left a comment

Choose a reason for hiding this comment