Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding signaling workflow information to the signal event. #338

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

ast2023
Copy link
Contributor

@ast2023 ast2023 commented Dec 16, 2023

What changed?
Added external_workflow_execution reference to History Signal Event attributes.

Why?
Allow signalling workflow information to be saved with the signal.

Breaking changes
No.

@ast2023 ast2023 requested review from a team as code owners December 16, 2023 00:13
Copy link
Member

@bergundy bergundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a suggestion for the comment, otherwise LGTM

Co-authored-by: Roey Berman <roey@temporal.io>
@ast2023 ast2023 changed the title adding signaling workflow information to the signal event adding signaling workflow information to the signal event. Dec 19, 2023
@ast2023 ast2023 enabled auto-merge (squash) December 19, 2023 01:33
@ast2023 ast2023 merged commit 5410b2a into master Dec 19, 2023
4 checks passed
@ast2023 ast2023 deleted the sasha/OSS-948 branch December 19, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants