Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hardcoded dcRedirectionPolicy parameter in server configmap #332

Merged
merged 1 commit into from
Dec 9, 2022
Merged

fix: hardcoded dcRedirectionPolicy parameter in server configmap #332

merged 1 commit into from
Dec 9, 2022

Conversation

vbatuev
Copy link
Contributor

@vbatuev vbatuev commented Nov 8, 2022

What was changed

  • removed harcoded dcRedirectionPolicy value from configmap template

Why?

  • user should be able to change dcRedirectionPolicy in values.yaml

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@vbatuev
fix: hadcoded dcRedirectionPolicy parameter in server configmap
6b7f722 
Signed-off-by: Victor Batuev <Victor.Batuev@ringcentral.com>
@CLAassistant
Copy link

CLAassistant commented Nov 8, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@mindaugasrukas mindaugasrukas changed the title fix: hadcoded dcRedirectionPolicy parameter in server configmap fix: hardcoded dcRedirectionPolicy parameter in server configmap Dec 9, 2022
mindaugasrukas
mindaugasrukas approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@mindaugasrukas mindaugasrukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mindaugasrukas mindaugasrukas merged commit 049f9d2 into temporalio:master Dec 9, 2022
omerosaienni pushed a commit to vhadianto/temporal-helm-charts that referenced this pull request May 11, 2023
@vbatuev @omerosaienni
fix: hadcoded dcRedirectionPolicy parameter in server configmap (temp…
04fd298 
…oralio#332)

Signed-off-by: Victor Batuev <Victor.Batuev@ringcentral.com>
omerosaienni pushed a commit to vhadianto/temporal-helm-charts that referenced this pull request May 11, 2023
@vbatuev @omerosaienni
fix: hadcoded dcRedirectionPolicy parameter in server configmap (temp…
d12faff 
…oralio#332)

Signed-off-by: Victor Batuev <Victor.Batuev@ringcentral.com>
omerosaienni pushed a commit to vhadianto/temporal-helm-charts that referenced this pull request May 11, 2023
@vbatuev @omerosaienni
fix: hadcoded dcRedirectionPolicy parameter in server configmap (temp…
8d68ea8 
…oralio#332)

Signed-off-by: Victor Batuev <Victor.Batuev@ringcentral.com>
omerosaienni pushed a commit to vhadianto/temporal-helm-charts that referenced this pull request May 14, 2023
@vbatuev @omerosaienni
fix: hadcoded dcRedirectionPolicy parameter in server configmap (temp…
9a83b08 
…oralio#332)

Signed-off-by: Victor Batuev <Victor.Batuev@ringcentral.com>
omerosaienni pushed a commit to vhadianto/temporal-helm-charts that referenced this pull request Jan 19, 2024
@vbatuev @omerosaienni
fix: hadcoded dcRedirectionPolicy parameter in server configmap (temp…
3394369 
…oralio#332)

Signed-off-by: Victor Batuev <Victor.Batuev@ringcentral.com>
omerosaienni pushed a commit to vhadianto/temporal-helm-charts that referenced this pull request Jan 19, 2024
@vbatuev @omerosaienni
fix: hadcoded dcRedirectionPolicy parameter in server configmap (temp…
1bc9baa 
…oralio#332)

Signed-off-by: Victor Batuev <Victor.Batuev@ringcentral.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexshtin alexshtin alexshtin approved these changes

@mindaugasrukas mindaugasrukas mindaugasrukas approved these changes

@Baladur Baladur Baladur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vbatuev @CLAassistant @alexshtin @mindaugasrukas @Baladur