Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove configmap of web #340

Closed
wants to merge 14 commits into from

Conversation

kwangil-ha
Copy link

What was changed

Why?

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kwangil-ha kwangil-ha requested review from a team as code owners December 14, 2022 08:17
@underrun
Copy link
Contributor

Thank you for the contribution! please sign our CLA if you would like us to accept your PRs. For now, the core problem has been solved via #341 - is there a separate need to not create a volume for a web config?

# Conflicts:
#	templates/server-deployment.yaml
#	templates/server-job.yaml
#	templates/web-deployment.yaml
#	values.yaml
@kwangil-ha kwangil-ha closed this Apr 26, 2023
@kwangil-ha kwangil-ha deleted the master_remove_configmap branch April 26, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants