Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for additionalEnv to schema jobs #408

Closed
wants to merge 1 commit into from

Conversation

weisdd
Copy link

@weisdd weisdd commented Jul 11, 2023

What was changed

Added support for additionalEnv to schema jobs (server-job.yaml).

Why?

Currently, the chart doesn't have a way to tune PostgreSQL TLS settings in the jobs that create/update schema. One of the ways to implement that support is through custom environment variables. E.g. for "required" mode, I need to pass:

        - name: SQL_TLS
           value: "true"
         - name: SQL_TLS_DISABLE_HOST_VERIFICATION
           value: "true"

Checklist

2. How was this tested:

Saved the values below to custom-values.yaml

schema:
  additionalEnv:
    - name: SQL_TLS
      value: "true"
    - name: SQL_TLS_DISABLE_HOST_VERIFICATION
      value: "true"

Then ran:

helm dependencies update
helm template . -f custom-values.yaml --show-only templates/server-job.yaml

The envs should appear in specs of the containers.

NOTE: It was added only to containers that already had section with environment variables. There's probably not much need for that for check-elasticsearch, create-elasticsearch-index, etc.

Signed-off-by: Igor Beliakov <demtis.register@gmail.com>
@weisdd weisdd requested review from a team as code owners July 11, 2023 16:15
@CLAassistant
Copy link

CLAassistant commented Jul 11, 2023

CLA assistant check
All committers have signed the CLA.

@grzegorz8
Copy link
Contributor

I've just created a PR for basically the same issue but in a different way :)

#411

@weisdd
Copy link
Author

weisdd commented Jul 22, 2023

@grzegorz8 that's nice :) I had actually thought of implementing something similar to what you added in the PR, though it was one of my last days on a project where temporal was planned to be used, so had to prefer the quicker option. Anyway, I'm happy that you had the time to make the chart more user-friendly :)

@weisdd weisdd closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants