-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure SQL TLS environment variables in server-job #411
Conversation
|
@grzegorz8 |
I meant that TLS related env variables are not set (SQL_TLS_KEY_FILE, SQL_TLS_CERT_FILE, etc). |
This is the error we recieved (without
|
Hi @grzegorz8 any update on this PR ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me - tested with Postgres 15 on RDS
Hi everyone! Any updates for this PR? |
@grzegorz8 Hi! Can you please update an example? It will be helpful |
1fd0e03
to
3b536c6
Compare
Example updated. Please check if it looks fine. |
Tested the Branch with Azure MySql with TLS enabled. Works. |
Hello! Wanted to bump this as it would be useful for us. Thank you! |
can someone clarify the status of this PR? we are using these changes without issues with postgresql versions 15.x |
# certFile: /path/to/certs/<client-cert-file> | ||
# keyFile: /path/to/certs/<client-key-file> | ||
|
||
# additionalVolumes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be indented so that they are under server
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robholland Thanks, fixed.
Looks good, one tiny tweak. |
Thanks for your contribution :) For future reference, when you've attended to feedback in PR, if you can re-request review from the reviewer, it helps us spot when something is ready for us to look at again. |
What was changed
Added support for
SQL_TLS*
properties in schema jobs (server-job.yaml
).Why?
Currently, when PostgreSQL database is secured with TLS, schema jobs are not properly configured.
In the Pull Request we reuse
server.config.persistence.*.sql.tls
,server.config.additionalVolumes
andserver.config.additionalVolumeMounts
properties..Checklist
Closes
No related issues.
How was this tested:
No updates needed.