Use incremental sequence number as ID for operations between lang and core #173

bergundy · 2021-08-16T15:00:51Z

Closes #164

@Sushisource I changed a lot in the prototype rust SDK and tests, I hope you like the new direction.

src/prototype_rust_sdk.rs

src/prototype_rust_sdk/workflow_context.rs

Sushisource · 2021-08-16T20:27:39Z

src/machines/patch_state_machine.rs

    /// EVENT_TYPE_WORKFLOW_TASK_SCHEDULED
    /// EVENT_TYPE_WORKFLOW_TASK_STARTED
    /// EVENT_TYPE_WORKFLOW_TASK_COMPLETED
    /// EVENT_TYPE_WORKFLOW_EXECUTION_COMPLETED
-    fn change_marker_single_timer(marker_type: MarkerType, timer_id: &str) -> TestHistoryBuilder {
+    fn patch_marker_single_activity(marker_type: MarkerType) -> TestHistoryBuilder {


Why change this to activity?

bergundy

Thanks, I'll fix what I can, not sure about exporting WFCommandFut.

src/prototype_rust_sdk.rs

src/prototype_rust_sdk/workflow_context.rs

Sushisource · 2021-08-16T20:28:44Z

src/machines/patch_state_machine.rs

+                    ActivityTaskCompletedEventAttributes {
+                        scheduled_event_id,
+                        started_event_id,
+                        // TODO result: Some(Payloads { payloads: vec![Payload{ metadata: Default::default(), data: vec![] }] }),


Leftover todos here and below

Sushisource · 2021-08-16T20:30:42Z

src/machines/timer_state_machine.rs

            cancel_timer_fut.await;
            Ok(().into())
        });

-        let t = canned_histories::cancel_timer("wait_timer", "cancel_timer");
+        let t = canned_histories::cancel_timer("1", "0");


I'm not necessarily saying we need to change this, but going from readable names to just numbers harms the readability of these tests some. It would be nice if we could still attach readable IDs to things with sequences somehow, but I understand it's possibly more work than it's worth.

The problem with timers is that they're correlated between the server and core by their timerId so the reasonable thing to do is use seq as the timerId.

Sushisource · 2021-08-17T17:12:48Z

src/prototype_rust_sdk/workflow_context.rs

+    /// We need a field that references the template type T, this works
+    unused: PhantomData<T>,


Can start w/ leading underscore - also doc comment not really necessary here, pretty common pattern.

Okay, I'll change

Sushisource · 2021-08-17T17:13:32Z

src/prototype_rust_sdk/workflow_context.rs

    }
 }

-impl Future for WFCommandFut {
-    type Output = UnblockEvent;
+impl<T> Unpin for WFCommandFut<T> where T: From<UnblockEvent> {}


I believe this should not be necessary, it should get auto-derived

It became necessary, complier was complaining, I think it's the phantom data.

Sushisource · 2021-08-17T17:19:09Z

src/prototype_rust_sdk/workflow_context.rs

+where
+    T: From<UnblockEvent>,
+{
+    fn cancel(&self, cx: &WfContext) {


In principle, the futures could probably store a ref to the WfContext and then it doesn't need to be passed here, but We don't really have to bother with that right away

let do that in the ... future 😉

Sushisource

Thanks this looks good!

bergundy requested a review from Sushisource August 16, 2021 15:00

bergundy requested a review from vitarb as a code owner August 16, 2021 15:00

bergundy self-assigned this Aug 16, 2021