Pass errors to the child workflow execution future #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quinn-With-Two-Ns
force-pushed
the
child-wf
branch
from
52776de
to
de4a037
Compare
| return nil | ||
| } | ||
|
|
||
| func DuplicateChildWorkflow(ctx workflow.Context) error { |
There was a problem hiding this comment.
This workflow will replay differently before and after my change, hence the use of SDK flags.
mmcshane
approved these changes
Mar 16, 2023
Quinn-With-Two-Ns
force-pushed
the
child-wf
branch
from
cff88ea
to
b987796
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass errors to the child workflow execution future. I had to version this because the change is technically non deterministic, I don't know if anyone would hit is, but I also don't understand why people launch duplicate child workflows so I am playing it safe.
resolves: #1041