Allow ignoring function ref issues #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quinn-With-Two-Ns
approved these changes
Jun 10, 2023
cretz
reviewed
Jun 12, 2023
| @@ -176,7 +180,17 @@ func (c *Checker) Run(pass *analysis.Pass) error { | |||
| } | |||
| // Report if couldn't get type | |||
| if fn == nil { | |||
| pass.Reportf(callExpr.Args[0].Pos(), "unrecognized function reference format") | |||
| _, isIgnored := ignoreMap[n] | |||
There was a problem hiding this comment.
I think a better impl is to change if callExpr == nil { above to if callExpr == nil || isIgnored {. You are ignoring RegisterWorkflow call so check it early.
cretz
reviewed
Jun 13, 2023
Comment on lines
+161
to
+167
| _, isIgnored := ignoreMap[n] | ||
| for k := range ignoreMap { | ||
| asExprStmt, _ := k.(*ast.ExprStmt) | ||
| if asExprStmt != nil && asExprStmt.X == n { | ||
| isIgnored = true | ||
| } | ||
| } |
There was a problem hiding this comment.
In retrospect, you could have just:
Suggested change
| _, isIgnored := ignoreMap[n] | |
| for k := range ignoreMap { | |
| asExprStmt, _ := k.(*ast.ExprStmt) | |
| if asExprStmt != nil && asExprStmt.X == n { | |
| isIgnored = true | |
| } | |
| } | |
| if _, isIgnored := ignoreMap[n]; isIgnored { | |
| return false | |
| } |
There was a problem hiding this comment.
That didn't seem to work when I was trying it - I needed to get this inner node for things to work
There was a problem hiding this comment.
I think it was because we were returning true which means "still traverse children" instead of false which means "stop here". Bonus of the stop-here approach is you can workflowcheck-ignore an entire function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows
//workflowcheck:ignoreto work on workflow function registration sites