-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental cloud operations client #1426
Conversation
This PR superseded this issue #1172 correct? |
Yes, closing that one now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issue on the code side, assuming we as an org want to do this.
# Conflicts: # contrib/datadog/go.mod # contrib/datadog/go.sum # contrib/opentelemetry/go.mod # contrib/opentelemetry/go.sum # contrib/opentracing/go.mod # contrib/opentracing/go.sum # contrib/tally/go.mod # contrib/tally/go.sum # go.mod # go.sum # test/go.mod # test/go.sum
@@ -2153,7 +2153,7 @@ func Test_NonDeterministicCheck(t *testing.T) { | |||
delete(commandTypes, cmd) | |||
} | |||
|
|||
require.Equal(t, 15, len(commandTypes), "If you see this error, you are adding new command type. "+ | |||
require.Equal(t, 17, len(commandTypes), "If you see this error, you are adding new command type. "+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, we expect this will be built by @bergundy and team as they build out Nexus support, this is just needed to pass CI
Updated API version. @anekkanti - can you review? |
I think we also should make samples for each SDK showing how to use the cloud API |
CI can't do the cloud test from forks because it requires secrets. I am going to close this and push to a local branch so the cloud test will run. |
What was changed
client.CloudOperationsClient
CloudService()
, but has room for high-level wrappers if we ever want themclient.DialCloudOperationsClient()
andclient.CloudOperationsClientOptions
(was blocked by temporalio/api#378, but now updated)