Experimental cloud operations client #1426
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
commented
Mar 22, 2024
7 tasks
|
This PR superseded this issue #1172 correct? |
|
Yes, closing that one now. |
Quinn-With-Two-Ns
approved these changes
Mar 22, 2024
# Conflicts: # contrib/datadog/go.mod # contrib/datadog/go.sum # contrib/opentelemetry/go.mod # contrib/opentelemetry/go.sum # contrib/opentracing/go.mod # contrib/opentracing/go.sum # contrib/tally/go.mod # contrib/tally/go.sum # go.mod # go.sum # test/go.mod # test/go.sum
cretz
commented
Apr 23, 2024
| @@ -2153,7 +2153,7 @@ func Test_NonDeterministicCheck(t *testing.T) { | |||
| delete(commandTypes, cmd) | |||
| } | |||
|
|
|||
| require.Equal(t, 15, len(commandTypes), "If you see this error, you are adding new command type. "+ | |||
| require.Equal(t, 17, len(commandTypes), "If you see this error, you are adding new command type. "+ | |||
There was a problem hiding this comment.
Note, we expect this will be built by @bergundy and team as they build out Nexus support, this is just needed to pass CI
cretz
commented
Apr 23, 2024
This was referenced May 9, 2024
|
Updated API version. @anekkanti - can you review? |
|
I think we also should make samples for each SDK showing how to use the cloud API |
|
CI can't do the cloud test from forks because it requires secrets. I am going to close this and push to a local branch so the cloud test will run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
client.CloudOperationsClientCloudService(), but has room for high-level wrappers if we ever want themclient.DialCloudOperationsClient()andclient.CloudOperationsClientOptions(was blocked by temporalio/api#378, but now updated)