Add google protoc plugin generated golang struct support #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
force-pushed
the
feature/test-jsonpb-enum
branch
from
b190117
to
a8a53a1
Compare
alexshtin
force-pushed
the
feature/test-jsonpb-enum
branch
from
a8a53a1
to
b66d212
Compare
alexshtin
changed the title
mfateev
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proto golang structs might be generated with 4 different protoc plugin versions:
Only case 4 was supported before. This PR add supports for cases 2 and 3 which are the same in this context. Case 1 is still not supported.
Also added test to verify that enum values are serialized properly.
https://community.temporal.io/t/protos-in-activities-arguments/555.
Also added better error message in case if value passed to
FromPayloadis not a pointer.