Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirmation of duplicate workflow ID behavior while running #574

Merged
merged 1 commit into from
Oct 6, 2021
Merged

Confirmation of duplicate workflow ID behavior while running #574

merged 1 commit into from
Oct 6, 2021

Conversation

cretz
Copy link
Member

@cretz cretz commented Oct 6, 2021

What was changed

Integration test confirming allow-duplicate behavior while workflow running

Why?

To check behavior brought up by #518

Sushisource
Sushisource approved these changes Oct 6, 2021
View reviewed changes
Copy link
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The bug can be closed with an explanation that this is working as expected.

@cretz cretz merged commit 4a53bc0 into temporalio:master Oct 6, 2021
@cretz cretz deleted the dupe-workflow-id branch October 6, 2021 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sushisource Sushisource Sushisource approved these changes

@alexshtin alexshtin Awaiting requested review from alexshtin

@mfateev mfateev Awaiting requested review from mfateev

@Spikhalskiy Spikhalskiy Awaiting requested review from Spikhalskiy

@vitarb vitarb Awaiting requested review from vitarb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cretz @Sushisource