Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom converter on workflow replayer #583

Merged
merged 5 commits into from
Oct 18, 2021

Conversation

cretz
Copy link
Member

@cretz cretz commented Oct 11, 2021

What was changed

Add options for workflow replayer and add first option as custom converter.

Why?

Need to be able to use data converter when replaying.

Checklist

  1. Closes NewWorkflowReplayer does not support custom data converter #571

Copy link
Member

@yiminc yiminc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for adding this.

@cretz cretz merged commit 345e00b into temporalio:master Oct 18, 2021
@cretz cretz deleted the replayer-with-converter branch October 18, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NewWorkflowReplayer does not support custom data converter
4 participants