Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preload type hints and remove global lookup cache #168

Merged
merged 2 commits into from
Oct 28, 2022
Merged

Preload type hints and remove global lookup cache #168

merged 2 commits into from
Oct 28, 2022

Conversation

cretz
Copy link
Member

@cretz cretz commented Oct 26, 2022

What was changed

No big changes. Moved code around so that argument and return type hints are on the workflow, signal, query, and activity definitions instead of obtained as needed with a global cache.

Why?

Global cache not only was unnecessary since most of these are preloaded into definitions anyways, but #159 showed we don't have a good cache key for functions anyways

Checklist

  1. Closes [Bug] Function type hint lookup cache key is bad #159

@cretz cretz requested a review from a team October 26, 2022 22:12
@cretz
Merge remote-tracking branch 'remotes/origin/main' into improve-type-…
594379d 
…hinting

# Conflicts:
#	temporalio/workflow.py
@cretz cretz merged commit 5259f4c into temporalio:main Oct 28, 2022
@cretz cretz deleted the improve-type-hinting branch October 28, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergundy bergundy bergundy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Function type hint lookup cache key is bad
2 participants
@cretz @bergundy