Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimental tag for schedules and add limited action check #330

Merged
merged 3 commits into from
Jun 16, 2023

Conversation

cretz
Copy link
Member

@cretz cretz commented Jun 15, 2023

What was changed

  • Remove warning saying schedules are experimental
  • Add check that requires limited actions be true on create when remaining actions are non-zero and vice-versa

Checklist

  1. Closes [Feature Request] Remove experimental warning from Schedules #320
  2. Closes [Bug] ScheduleState.limited_actions doc is invalid #316

@cretz cretz requested a review from a team as a code owner June 15, 2023 21:48
@@ -2982,7 +2935,9 @@ class ScheduleState:
"""
If true, remaining actions will be decremented for each action taken.

Cannot be set on create.
On schedule create, this must be set to true on if
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
On schedule create, this must be set to true on if
On schedule create, this must be set to true if

@cretz cretz merged commit 6a3662c into temporalio:main Jun 16, 2023
11 checks passed
@cretz cretz deleted the schedule-doc-update branch June 16, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants