Measure backlog after completing current task (#4562)

temporalio · Jun 30, 2023 · 0fcff51 · 0fcff51
1 parent 316e876
commit 0fcff51
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/service/matching/matchingEngine.go b/service/matching/matchingEngine.go
@@ -1327,7 +1327,9 @@ func (e *matchingEngineImpl) createPollWorkflowTaskQueueResponse(
 	if task.query != nil {
 		response.Query = task.query.request.QueryRequest.Query
 	}
-	response.BacklogCountHint = task.backlogCountHint
+	if task.backlogCountHint != nil {
+		response.BacklogCountHint = task.backlogCountHint()
+	}
 	return response
 }
 

diff --git a/service/matching/matchingEngine_test.go b/service/matching/matchingEngine_test.go
@@ -399,7 +399,7 @@ func (s *matchingEngineSuite) TestPollWorkflowTaskQueues() {
 		StartedEventId:         common.EmptyEventID,
 		Attempt:                1,
 		NextEventId:            common.EmptyEventID,
-		BacklogCountHint:       1,
+		BacklogCountHint:       0,
 		StickyExecutionEnabled: true,
 		Query:                  nil,
 		TransientWorkflowTask:  nil,

diff --git a/service/matching/task.go b/service/matching/task.go
@@ -61,7 +61,7 @@ type (
 		source           enumsspb.TaskSource
 		forwardedFrom    string     // name of the child partition this task is forwarded from (empty if not forwarded)
 		responseC        chan error // non-nil only where there is a caller waiting for response (sync-match)
-		backlogCountHint int64
+		backlogCountHint func() int64
 	}
 )
 

diff --git a/service/matching/taskQueueManager.go b/service/matching/taskQueueManager.go
@@ -479,7 +479,7 @@ func (c *taskQueueManagerImpl) GetTask(
 	}
 
 	task.namespace = c.namespace
-	task.backlogCountHint = c.taskAckManager.getBacklogCountHint()
+	task.backlogCountHint = c.taskAckManager.getBacklogCountHint
 	return task, nil
 }