Fix list batch operation to include division (#3431)

* Fix list batch operation to include division
temporalio · Sep 29, 2022 · 3c0105b · 3c0105b
1 parent 02e2edf
commit 3c0105b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/service/frontend/workflow_handler.go b/service/frontend/workflow_handler.go
@@ -3950,7 +3950,12 @@ func (wh *WorkflowHandler) ListBatchOperations(
 		Namespace:     request.GetNamespace(),
 		PageSize:      int32(wh.config.VisibilityMaxPageSize(request.GetNamespace())),
 		NextPageToken: request.GetNextPageToken(),
-		Query:         fmt.Sprintf("%s = '%s'", searchattribute.WorkflowType, batcher.BatchWFTypeName),
+		Query: fmt.Sprintf("%s = '%s' and %s='%s'",
+			searchattribute.WorkflowType,
+			batcher.BatchWFTypeName,
+			searchattribute.TemporalNamespaceDivision,
+			batcher.NamespaceDivision,
+		),
 	})
 	if err != nil {
 		return nil, err

diff --git a/service/frontend/workflow_handler_test.go b/service/frontend/workflow_handler_test.go
@@ -27,6 +27,7 @@ package frontend
 import (
 	"context"
 	"errors"
+	"strings"
 	"testing"
 	"time"
 
@@ -2261,7 +2262,7 @@ func (s *workflowHandlerSuite) TestListBatchOperations() {
 			_ context.Context,
 			request *manager.ListWorkflowExecutionsRequestV2,
 		) (*manager.ListWorkflowExecutionsResponse, error) {
-
+			s.True(strings.Contains(request.Query, searchattribute.TemporalNamespaceDivision))
 			return &manager.ListWorkflowExecutionsResponse{
 				Executions: []*workflowpb.WorkflowExecutionInfo{
 					{Execution: &commonpb.WorkflowExecution{