Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list batch operation to include division #3431

Merged
merged 2 commits into from Sep 26, 2022

Conversation

yux0
Copy link
Contributor

@yux0 yux0 commented Sep 26, 2022

What changed?
Fix list batch operation to include division.

Why?
Need to use namespace division to show the batch operation.

How did you test it?
Local test

Potential risks

Is hotfix candidate?

@yux0 yux0 requested a review from a team as a code owner September 26, 2022 18:19
@feedmeapples feedmeapples mentioned this pull request Sep 26, 2022
Copy link
Member

@yiminc yiminc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add an integration test to cover ListBatchOperations.

@yux0 yux0 merged commit f4af2d5 into temporalio:master Sep 26, 2022
@yux0 yux0 deleted the fix-list-batch branch September 26, 2022 19:41
dnr pushed a commit that referenced this pull request Sep 29, 2022
* Fix list batch operation to include division
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants