Add more logs for debugging namespace handover issue

temporalio · Mar 21, 2022 · 74f14ee · 74f14ee
1 parent 873b4ce
commit 74f14ee
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/service/history/shard/context_impl.go b/service/history/shard/context_impl.go
@@ -494,6 +494,14 @@ func (s *ContextImpl) UpdateHandoverNamespaces(namespaces []*namespace.Namespace
 			delete(s.handoverNamespaces, k)
 		}
 	}
+
+	var namespaceNames []string
+	for _, ns := range namespaces {
+		namespaceNames = append(namespaceNames, ns.Name().String())
+	}
+
+	s.GetLogger().Info("Namespace handover info updated.", tag.TaskID(maxRepTaskID), tag.NewAnyTag("namespace-names", namespaceNames),
+		tag.ShardID(s.shardID), tag.NewAnyTag("handover-namespace-info", s.handoverNamespaces))
 }
 
 func (s *ContextImpl) GetTimerMaxReadLevel(cluster string) time.Time {

diff --git a/service/worker/migration/workflow.go b/service/worker/migration/workflow.go
@@ -552,6 +552,10 @@ func (a *activities) checkHandoverOnce(ctx context.Context, waitRequest waitHand
 		metrics.TargetClusterTag(waitRequest.RemoteCluster),
 		metrics.NamespaceTag(waitRequest.Namespace),
 	).UpdateGauge(metrics.HandoverReadyShardCountGauge, float64(readyShardCount))
+	a.logger.Info("Wait handover ready shard count.",
+		tag.NewInt("ReadyShards", readyShardCount),
+		tag.NewStringTag("Namespace", waitRequest.Namespace),
+		tag.NewStringTag("RemoteCluster", waitRequest.RemoteCluster))
 
 	return readyShardCount == len(resp.Shards), nil
 }