Skip to content

Commit

Permalink
Remove replication start event sanity check (#2616)
Browse files Browse the repository at this point in the history
  • Loading branch information
yux0 committed Mar 17, 2022
1 parent 27d4266 commit 873b4ce
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
5 changes: 0 additions & 5 deletions service/frontend/adminHandler.go
Original file line number Diff line number Diff line change
Expand Up @@ -1577,11 +1577,6 @@ func (adh *AdminHandler) validateGetWorkflowExecutionRawHistoryV2Request(
return errInvalidEventQueryRange
}

if (request.GetStartEventId() != common.EmptyEventID && request.GetStartEventVersion() == common.EmptyVersion) ||
(request.GetStartEventId() == common.EmptyEventID && request.GetStartEventVersion() != common.EmptyVersion) {
return errInvalidStartEventCombination
}

return nil
}

Expand Down
2 changes: 0 additions & 2 deletions service/frontend/errors.go
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,6 @@ var (
errInvalidPageSize = serviceerror.NewInvalidArgument("Invalid PageSize.")
errInvalidPaginationToken = serviceerror.NewInvalidArgument("Invalid pagination token.")
errInvalidFirstNextEventCombination = serviceerror.NewInvalidArgument("Invalid FirstEventId and NextEventId combination.")
errInvalidStartEventCombination = serviceerror.NewInvalidArgument("Invalid StartEventId and StartEventVersion combination.")
errInvalidEndEventCombination = serviceerror.NewInvalidArgument("Invalid EndEventId and EndEventVersion combination.")
errInvalidVersionHistories = serviceerror.NewInvalidArgument("Invalid version histories.")
errInvalidEventQueryRange = serviceerror.NewInvalidArgument("Invalid event query range.")
errDLQTypeIsNotSupported = serviceerror.NewInvalidArgument("The DLQ type is not supported.")
Expand Down

0 comments on commit 873b4ce

Please sign in to comment.