Skip to content

Commit

Permalink
Assign fx pass in raw task converter (#4679)
Browse files Browse the repository at this point in the history
<!-- Describe what has changed in this PR -->
**What changed?**
Assign fx pass in raw task converter

<!-- Tell your future self why have you made these changes -->
**Why?**
Assign fx pass in raw task converter

<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
**How did you test it?**
Found in functional test

<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
**Potential risks**


<!-- Is this PR a hotfix candidate or require that a notification be
sent to the broader community? (Yes/No) -->
**Is hotfix candidate?**
  • Loading branch information
yux0 authored and wxing1292 committed Jul 25, 2023
1 parent 45e0054 commit d24a7fa
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions service/history/fx.go
Expand Up @@ -142,8 +142,9 @@ func HandlerProvider(args NewHandlerArgs) *Handler {
eventNotifier: args.EventNotifier,
tracer: args.TracerProvider.Tracer(consts.LibraryName),

replicationTaskFetcherFactory: args.ReplicationTaskFetcherFactory,
streamReceiverMonitor: args.StreamReceiverMonitor,
replicationTaskFetcherFactory: args.ReplicationTaskFetcherFactory,
replicationTaskConverterProvider: args.ReplicationTaskConverterFactory,
streamReceiverMonitor: args.StreamReceiverMonitor,
}

// prevent us from trying to serve requests before shard controller is started and ready
Expand Down

0 comments on commit d24a7fa

Please sign in to comment.