Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign fx pass in raw task converter #4679

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

yux0
Copy link
Contributor

@yux0 yux0 commented Jul 25, 2023

What changed?
Assign fx pass in raw task converter

Why?
Assign fx pass in raw task converter

How did you test it?
Found in functional test

Potential risks

Is hotfix candidate?

@yux0 yux0 requested a review from a team as a code owner July 25, 2023 02:15
@yux0 yux0 enabled auto-merge (squash) July 25, 2023 03:26
@yux0 yux0 merged commit fa1597b into temporalio:master Jul 25, 2023
10 checks passed
wxing1292 pushed a commit that referenced this pull request Jul 25, 2023
<!-- Describe what has changed in this PR -->
**What changed?**
Assign fx pass in raw task converter

<!-- Tell your future self why have you made these changes -->
**Why?**
Assign fx pass in raw task converter

<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
**How did you test it?**
Found in functional test

<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
**Potential risks**


<!-- Is this PR a hotfix candidate or require that a notification be
sent to the broader community? (Yes/No) -->
**Is hotfix candidate?**
wxing1292 pushed a commit that referenced this pull request Jul 26, 2023
<!-- Describe what has changed in this PR -->
**What changed?**
Assign fx pass in raw task converter

<!-- Tell your future self why have you made these changes -->
**Why?**
Assign fx pass in raw task converter

<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
**How did you test it?**
Found in functional test

<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
**Potential risks**


<!-- Is this PR a hotfix candidate or require that a notification be
sent to the broader community? (Yes/No) -->
**Is hotfix candidate?**
wxing1292 pushed a commit that referenced this pull request Jul 27, 2023
<!-- Describe what has changed in this PR -->
**What changed?**
Assign fx pass in raw task converter

<!-- Tell your future self why have you made these changes -->
**Why?**
Assign fx pass in raw task converter

<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
**How did you test it?**
Found in functional test

<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
**Potential risks**


<!-- Is this PR a hotfix candidate or require that a notification be
sent to the broader community? (Yes/No) -->
**Is hotfix candidate?**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants