Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement history node deletion logic #1443

Merged
merged 1 commit into from Apr 13, 2021

Conversation

wxing1292
Copy link
Contributor

@wxing1292 wxing1292 commented Apr 8, 2021

What changed?

  • SQL: Rename SelectFromHistoryNode to RangeSelectFromHistoryNode
  • SQL: Rename DeleteFromHistoryNode to RangeDeleteFromHistoryNode
  • SQL: New DeleteFromHistoryNode aiming to delete one record from history node table

Why?
Pre-requisite of events chaining

How did you test it?
Existing test & new tests

Potential risks
N/A

Is hotfix candidate?
No

@wxing1292 wxing1292 requested a review from alexshtin April 8, 2021 18:41
@wxing1292 wxing1292 force-pushed the events-chaining-delete-node branch 4 times, most recently from e1509f0 to d60c9fa Compare April 8, 2021 22:56
* SQL: Rename SelectFromHistoryNode to RangeSelectFromHistoryNode
* SQL: Rename DeleteFromHistoryNode to RangeDeleteFromHistoryNode
* SQL: New DeleteFromHistoryNode aiming to delete one record from history node table
@wxing1292 wxing1292 marked this pull request as ready for review April 13, 2021 23:15
@wxing1292 wxing1292 requested a review from a team April 13, 2021 23:15
@wxing1292 wxing1292 enabled auto-merge (squash) April 13, 2021 23:16
@wxing1292 wxing1292 merged commit 1b1aef9 into temporalio:master Apr 13, 2021
@wxing1292 wxing1292 deleted the events-chaining-delete-node branch April 13, 2021 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants