Implement history node validation & trimming logic #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
force-pushed
the
events-chaining-trim
branch
7 times, most recently
from
f6e4289
to
2b32d5a
Compare
* Add dedicated E2E UT for history events store
wxing1292
force-pushed
the
events-chaining-trim
branch
from
2b32d5a
to
419d040
Compare
alexshtin
reviewed
Apr 14, 2021
| return nodesToTrim, nil | ||
| } | ||
|
|
||
| func indexNodeIDToNode( |
There was a problem hiding this comment.
Suggested change
| func indexNodeIDToNode( | |
| func indexNodeIDToNodesMetadata( |
alexshtin
approved these changes
Apr 14, 2021
Co-authored-by: Alex Shtin <alex@shtin.com>
This was referenced Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
In case of mutable state inconsistency, either due to our bug or DB returning stale data, new (and invalid) history node with higher transaction ID will shadow the valid history node. Although update of mutable state is protected by CAS, the new (and invalid) history is still present in DB. TrimHistoryBranch API is introduced for to trim this kind of invalid history nodes.
How did you test it?
New tests
Potential risks
Core functionality modification, tested by new tests.
Is hotfix candidate?
No