Add additional service protection against data inconsistency #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Trigger TrimHistoryBranch operation if GetWorkflowExecutionHistory sees dataloss error * Rename last_history_node_txn_id to last_first_event_txn_id
wxing1292
force-pushed
the
events-chaining-wire
branch
from
f2914fb
to
8837ccd
Compare
wxing1292
changed the title
alexshtin
approved these changes
Apr 15, 2021
| @@ -590,6 +592,19 @@ func (wh *WorkflowHandler) GetWorkflowExecutionHistory(ctx context.Context, requ | |||
| continuationToken.IsWorkflowRunning = isWorkflowRunning | |||
| continuationToken.PersistenceToken = nil | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Can you list potential functions that might return *serviceerror.DataLoss here. And also some sort of TODO comment to move this close to history store.
…roto Co-authored-by: Alex Shtin <alex@shtin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Additional service protection, also see #1449
How did you test it?
Existing tests
Potential risks
N/A
Is hotfix candidate?
No