Change CLI default TLS host name verification behavior #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* CLI TLS default to perform host name verification * Remove CLI TLS enable host verification flag, `tls_enable_host_verification` and `tls-enable-host-verification` * Add CLI TLS disable host verification flag `tls_disable_host_verification` and `tls-disable-host-verification`
wxing1292
force-pushed
the
cli-host-verification
branch
from
0e168de
to
58d26f1
Compare
mastermanu
reviewed
Apr 20, 2021
mastermanu
reviewed
Apr 20, 2021
mastermanu
reviewed
Apr 20, 2021
mastermanu
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
tls_enable_host_verificationandtls-enable-host-verificationtls_disable_host_verificationandtls-disable-host-verificationWhy?
Changing the default behavior for better security reasons
How did you test it?
Manual tests & CICD
Potential risks
CLI behavior breaking change
Is hotfix candidate?
No