Add TLS host name override config for Cassandra / SQL tool #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastermanu
approved these changes
Apr 20, 2021
mastermanu
approved these changes
Apr 20, 2021
* Allow overriding host name for TLS host name verification * Disable TLS host name verification when `tls_disable_host_verification` or `tls-disable-host-verification` is set
wxing1292
force-pushed
the
cli-host-name
branch
from
689250c
to
8a13ae3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
tls_disable_host_verificationortls-disable-host-verificationis setWhy?
Disable TLS host name verification when
tls_disable_host_verificationortls-disable-host-verificationis set since user need to explicitly set this flag to disable the verificationHow did you test it?
CICD
Potential risks
same as #1478, behavior change
Is hotfix candidate?
No