Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error handling for standby transfer task verification #3050

Merged
merged 1 commit into from
Jul 2, 2022
Merged

Improve error handling for standby transfer task verification #3050

merged 1 commit into from
Jul 2, 2022

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Jul 1, 2022

What changed?

  • Handle unimplemented errors when calling verification api by skipping the verification
  • Do not clear mutable state cache when verification api fails as there's no error in the current workflow.

Why?

  • Improve error handling.

How did you test it?

  • Added unit test

Potential risks

Is hotfix candidate?

  • Yes

@yycptt yycptt requested a review from a team as a code owner July 1, 2022 21:14
@yycptt yycptt merged commit ca22f60 into temporalio:master Jul 2, 2022
@yycptt yycptt deleted the improve-verification-error-handling branch July 2, 2022 00:11
alexshtin pushed a commit that referenced this pull request Jul 8, 2022
@yycptt @alexshtin
Improve error handling for standby transfer task verification (#3050)
0b01a72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yux0 yux0 yux0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yycptt @yux0 @alexshtin