Fix replication task execution latency #3671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
approved these changes
Nov 28, 2022
rodrigozhou
reviewed
Nov 28, 2022
There was a problem hiding this comment.
Changes look good to me, but wondering if it would be better to have an util function for this instead of creating lambda functions all over the code. Something like this:
func RecordLatency(startTime time.Time, metric metrics.TimerMetric, tags ...metrics.Tag) {
metric.Record(time.Since(startTime), tags...)
}
yux0
added a commit
that referenced
this pull request
Nov 28, 2022
* Fix replication task execution latency * Fix emit latency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fix pattern on defer when emitting latency metrics.
Why?
Cannot call timer in defer directly.
How did you test it?
Potential risks
Is hotfix candidate?
Yes