Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add force-continue-as-new signal to schedule workflow #5034

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

dnr
Copy link
Member

@dnr dnr commented Oct 25, 2023

What changed?
Add force-continue-as-new signal to schedule workflow, to force it to continue-as-new immediately.

Why?
This could be used to force all running schedules onto the newest version of the workflow code, to allow retiring older code paths.

How did you test it?
unit test

Potential risks

Is hotfix candidate?

@dnr dnr requested a review from a team as a code owner October 25, 2023 00:44
dnr added a commit to dnr/temporal that referenced this pull request Oct 25, 2023
@dnr dnr merged commit 974fea8 into temporalio:main Oct 30, 2023
10 checks passed
@dnr dnr deleted the sched70 branch October 30, 2023 17:35
rodrigozhou pushed a commit that referenced this pull request Oct 30, 2023
**What changed?**
Add `force-continue-as-new` signal to schedule workflow, to force it to
continue-as-new immediately.

**Why?**
This could be used to force all running schedules onto the newest
version of the workflow code, to allow retiring older code paths.

**How did you test it?**
unit test
rodrigozhou pushed a commit that referenced this pull request Oct 31, 2023
**What changed?**
Add `force-continue-as-new` signal to schedule workflow, to force it to
continue-as-new immediately.

**Why?**
This could be used to force all running schedules onto the newest
version of the workflow code, to allow retiring older code paths.

**How did you test it?**
unit test
dnr added a commit that referenced this pull request Nov 7, 2023
**What changed?**
Tweak schedule settings to activate changes in #4990 and #5034

**Why?**
Make it work

**How did you test it?**
existing tests
rodrigozhou pushed a commit that referenced this pull request Nov 30, 2023
**What changed?**
Tweak schedule settings to activate changes in #4990 and #5034

**Why?**
Make it work

**How did you test it?**
existing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants