Use ContinueAsNewSuggested in scheduler workflow #4990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
reviewed
Oct 18, 2023
| suggestContinueAsNew = suggestContinueAsNew || iters <= 0 | ||
| iters-- | ||
| } else { | ||
| suggestContinueAsNew = suggestContinueAsNew || info.GetContinueAsNewSuggested() |
There was a problem hiding this comment.
You need to use getVersion here since this may eagerly decide to continue as new
There was a problem hiding this comment.
This workflow uses a MutableSideEffect of tweakablePolicies to get the same effect as the versioning api, but in bulk. IterationsBeforeContinueAsNew has always been > 0, we'll change it to 0 to activate this code path (in a separate PR to allow this one to go in a patch release to enable downgrade)
There was a problem hiding this comment.
Okay, I was missing that context. Thanks. LGTM.
bergundy
approved these changes
Oct 20, 2023
dnr
added a commit
to dnr/temporal
that referenced
this pull request
Oct 25, 2023
rodrigozhou
pushed a commit
that referenced
this pull request
Oct 30, 2023
**What changed?** Scheduler workflow uses server-sent suggestion for when to continue-as-new instead of fixed iteration count. Note this is not enabled in this PR yet. **Why?** Automatically handle history size/event count too large conditions (or any future conditions added by the server), which we might get if we do more work than expected per iteration. **How did you test it?** new unit tests, also replaced for loop with previous version to verify actual iteration count didn't change **Potential risks** The default history size suggestion is at 4MB, which we could hit after just a few large payload responses, and then we'd do continue-as-new more often than we might like.
rodrigozhou
pushed a commit
that referenced
this pull request
Oct 31, 2023
**What changed?** Scheduler workflow uses server-sent suggestion for when to continue-as-new instead of fixed iteration count. Note this is not enabled in this PR yet. **Why?** Automatically handle history size/event count too large conditions (or any future conditions added by the server), which we might get if we do more work than expected per iteration. **How did you test it?** new unit tests, also replaced for loop with previous version to verify actual iteration count didn't change **Potential risks** The default history size suggestion is at 4MB, which we could hit after just a few large payload responses, and then we'd do continue-as-new more often than we might like.
rodrigozhou
pushed a commit
that referenced
this pull request
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Scheduler workflow uses server-sent suggestion for when to continue-as-new instead of fixed iteration count.
Note this is not enabled in this PR yet.
Why?
Automatically handle history size/event count too large conditions (or any future conditions added by the server), which we might get if we do more work than expected per iteration.
How did you test it?
new unit tests, also replaced for loop with previous version to verify actual iteration count didn't change
Potential risks
The default history size suggestion is at 4MB, which we could hit after just a few large payload responses, and then we'd do continue-as-new more often than we might like.