Implement Nexus outgoing service registry #5523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSnowden
force-pushed
the
snowden/operator-service
branch
2 times, most recently
from
2401e8e
to
7360d42
Compare
MichaelSnowden
force-pushed
the
snowden/operator-service
branch
from
7360d42
to
84390db
Compare
MichaelSnowden
force-pushed
the
snowden/operator-service
branch
from
84390db
to
25f0d31
Compare
MichaelSnowden
force-pushed
the
snowden/operator-service
branch
from
ec2919f
to
76d4a82
Compare
bergundy
reviewed
Mar 14, 2024
proto/internal/temporal/server/api/persistence/v1/namespaces.proto
Outdated
Show resolved
Hide resolved
proto/internal/temporal/server/api/persistence/v1/namespaces.proto
Outdated
Show resolved
Hide resolved
Co-authored-by: Roey Berman <roey@temporal.io>
bergundy
approved these changes
Mar 19, 2024
MichaelSnowden
added a commit
that referenced
this pull request
Mar 20, 2024
## What changed? <!-- Describe what has changed in this PR --> There was a small issue in #5523 where we check an "issue set" against nil in the outgoing service registry code. The issue set is supposed to track a list of request issues to form one big invalid argument error if its length is greater than zero. However, we had code that looked like this: ```go if issues := getIssuesFromCommonRequest(req); issues != nil { return nil, issues.GetError() } ``` Which works because we return a nil issues set if there's no issues, but, technically, we could have a non-nil issues set with no issues, so it should instead be something like this: ```go if err := getIssuesFromCommonRequest(req).GetError(); err != nil { return nil, err } ``` ## Why? <!-- Tell your future self why have you made these changes --> ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
I implemented the operator service CRUD APIs for Nexus outgoing services.
Why?
How did you test it?
There's nearly 100% test coverage across unit tests and functional tests. It's only not 100% because of redundancy between create / update.
Potential risks
Documentation
Is hotfix candidate?