Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly update workflow transition history #5885

Merged
merged 3 commits into from
May 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions common/persistence/versionhistory/version_history.go
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ func GetVersionHistoryEventVersion(v *historyspb.VersionHistory, eventID int64)
return 0, err
}
if eventID < common.FirstEventID || eventID > lastItem.GetEventId() {
return 0, serviceerror.NewInternal("input event ID is not in range.")
return 0, serviceerror.NewInternal(fmt.Sprintf("input event ID is not in range, eventID: %v", eventID))
}

// items are sorted by eventID & version
Expand All @@ -239,7 +239,7 @@ func GetVersionHistoryEventVersion(v *historyspb.VersionHistory, eventID int64)
return currentItem.GetVersion(), nil
}
}
return 0, serviceerror.NewInternal("input event ID is not in range.")
return 0, serviceerror.NewInternal(fmt.Sprintf("input event ID is not in range, eventID: %v", eventID))
}

// IsEmptyVersionHistory indicate whether version history is empty
Expand Down
2 changes: 1 addition & 1 deletion config/development-cluster-a.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -115,5 +115,5 @@ namespaceDefaults:
URI: "file:///tmp/temporal_vis_archival/development"

dynamicConfigClient:
filepath: "config/dynamicconfig/development-cass.yaml"
filepath: "config/dynamicconfig/development-xdc.yaml"
pollInterval: "10s"
2 changes: 1 addition & 1 deletion config/development-cluster-b.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -119,5 +119,5 @@ namespaceDefaults:
URI: "file:///tmp/temporal_vis_archival/development"

dynamicConfigClient:
filepath: "config/dynamicconfig/development-cass.yaml"
filepath: "config/dynamicconfig/development-xdc.yaml"
pollInterval: "10s"
2 changes: 1 addition & 1 deletion config/development-cluster-c.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -119,5 +119,5 @@ namespaceDefaults:
URI: "file:///tmp/temporal_vis_archival/development"

dynamicConfigClient:
filepath: "config/dynamicconfig/development-cass.yaml"
filepath: "config/dynamicconfig/development-xdc.yaml"
pollInterval: "10s"
57 changes: 57 additions & 0 deletions config/dynamicconfig/development-xdc.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
#frontend.enableClientVersionCheck:
#- value: true
# constraints: {}
#history.persistenceMaxQPS:
#- value: 3000
# constraints: {}
#frontend.persistenceMaxQPS:
#- value: 3000
# constraints: {}
#frontend.throttledLogRPS:
#- value: 20
# constraints: {}
#history.defaultActivityRetryPolicy:
#- value:
# InitialIntervalInSeconds: 1
# MaximumIntervalCoefficient: 100.0
# BackoffCoefficient: 2.0
# MaximumAttempts: 0
#history.defaultWorkflowRetryPolicy:
#- value:
# InitialIntervalInSeconds: 1
# MaximumIntervalCoefficient: 100.0
# BackoffCoefficient: 2.0
# MaximumAttempts: 0
#system.secondaryVisibilityWritingMode:
# - value: "off"
# constraints: {}
#system.enableReadFromSecondaryVisibility:
# - value: false
# constraints: {}
#system.enableParentClosePolicyWorker:
# - value: true
system.enableEagerWorkflowStart:
- value: true
frontend.enableUpdateWorkflowExecution:
- value: true
frontend.enableUpdateWorkflowExecutionAsyncAccepted:
- value: true
frontend.workerVersioningDataAPIs:
- value: true
frontend.workerVersioningWorkflowAPIs:
- value: true
frontend.accessHistoryFraction:
- value: 1.0
frontend.adminDeleteAccessHistoryFraction:
- value: 1.0
system.enableNexus:
# enableNexus also controls transition history which can't be enabled now
- value: false
yycptt marked this conversation as resolved.
Show resolved Hide resolved
component.nexusoperations.callback.endpoint.template:
- value: http://localhost:7243/api/v1/namespaces/{{.NamespaceName}}/nexus/callback
matching.queryWorkflowTaskTimeoutLogRate:
- value: 1.0
history.ReplicationEnableUpdateWithNewTaskMerge:
- value: true
history.enableWorkflowExecutionTimeoutTimer:
- value: true
Loading
Loading