Fix prometheus warning message #5932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norberthu
approved these changes
May 15, 2024
stephanos
approved these changes
May 15, 2024
ychebotarev
pushed a commit
to ychebotarev/temporal
that referenced
this pull request
May 16, 2024
## What changed?
<!-- Describe what has changed in this PR -->
Fix prometheus warning message by adding `namespace` tag.
```
{"level":"warn","ts":"2024-05-14T15:14:32.598-0700","msg":"error in prometheus reporter","error":"a previously registered descriptor with the same fully-qualified name as Desc{fqName: \"AccessHistoryNew\", help: \"AccessHistoryNew counter\", constLabels: {}, variableLabels: {operation,namespace,service_name}} has different label names or a different help string","logging-call-at":"config.go:432"}
```
Note: code will be removed very soon.
## Why?
<!-- Tell your future self why have you made these changes -->
Set of tags must be the same on the same metric. I hope it fixes temporalio#5897.
## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
Run it locally and checked logs with eyeballing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fix prometheus warning message by adding
namespacetag.Note: code will be removed very soon.
Why?
Set of tags must be the same on the same metric. I hope it fixes #5897.
How did you test it?
Run it locally and checked logs with eyeballing.