Adds check-health command to temporal-cassandra-tool and switches start.sh to use that instead of cqlsh #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feedmeapples
approved these changes
Oct 21, 2020
markmark206
approved these changes
Oct 21, 2020
| return handleErr(fmt.Errorf("unable to establish CQL session:%+v", err)) | ||
| } | ||
|
|
||
| defer client.Close() |
There was a problem hiding this comment.
i guess we don't even need to defer, but this is good regression-proofing. ; )
feedmeapples
approved these changes
Oct 21, 2020
alexshtin
reviewed
Oct 21, 2020
alexshtin
approved these changes
Oct 21, 2020
|
(PS oh and it might be worthwhile to create a ticket to track adding this to |
…fix_wait_for_cassandra
…al into fix_wait_for_cassandra
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two changes:
This change will enable auto-setup to work against a Cassandra DB configured with TLS or username/password when launching from the docker-compose file.
Tested auto-setup locally and the check-health command against a deployed Cassandra environment with username/password and mTLS enabled.
Low risk change