Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

Add optional flag to bind frontend ip address #17

Merged
merged 2 commits into from
Dec 1, 2021
Merged

Add optional flag to bind frontend ip address #17

merged 2 commits into from
Dec 1, 2021

Conversation

jbreiding
Copy link
Contributor

What changed?
Adding an optional flag to bind frontend to an IP address instead of localhost.

Why?
In order to expose the frontend service from a docker container.

How did you test it?
Locally using https://github.com/jbreiding/potential-goggles

Potential risks
Optional flag

Is hotfix candidate?
No

@codecov-commenter
Copy link

Codecov Report

Merging #17 (f09e76b) into main (50d4a31) will decrease coverage by 1.57%.
The diff coverage is 35.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
- Coverage   46.49%   44.92%   -1.58%     
==========================================
  Files          11       11              
  Lines         628      650      +22     
==========================================
  Hits          292      292              
- Misses        318      339      +21     
- Partials       18       19       +1     
Impacted Files Coverage Δ
cmd/temporalite/main.go 1.85% <0.00%> (-0.28%) ⬇️
options.go 56.41% <0.00%> (-6.45%) ⬇️
internal/liteconfig/config.go 87.05% <75.00%> (-2.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50d4a31...f09e76b. Read the comment docs.

Copy link
Collaborator

@jlegrone jlegrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me after a couple small doc updates. Thank you!

cmd/temporalite/main.go Outdated Show resolved Hide resolved
options.go Outdated Show resolved Hide resolved
cmd/temporalite/main.go Outdated Show resolved Hide resolved
@jlegrone jlegrone enabled auto-merge (squash) December 1, 2021 16:14
@jlegrone jlegrone merged commit 6070027 into temporalio:main Dec 1, 2021
@jbreiding jbreiding deleted the frontend-ip-address branch December 11, 2021 17:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants