Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

Upgrade Temporal and Temporal Web UI. #86

Merged
merged 3 commits into from
Jul 20, 2022

Conversation

robholland
Copy link
Contributor

What changed?

Temporal and Temporal Web UI versions upgraded.

Why?

To benefit from the improved web UI.

How did you test it?

Ran locally and in gitpod.

Potential risks

None.

Is hotfix candidate?

No.

@jlegrone
Copy link
Collaborator

jlegrone commented Jun 28, 2022

Thanks! Do you have time to verify that the modernc sqlite implementation respects pragma configuration in the same format? Right now we only support journal_mode and synchronous. https://github.com/DataDog/temporalite/blob/f255907062d91bdd4b1e6830c6e76db5f9d56900/internal/liteconfig/config.go#L120

@robholland
Copy link
Contributor Author

It is not compatible, I will adjust the code.

@robholland
Copy link
Contributor Author

Hmm, this is not as straight forward as I first thought. I believe the Temporal SQLite plugin API does not allow using more than one pragma because ConnectAttributes is a map[string]string but the modenc SQLite API requires repeating the _pragma=... URL parameter once per pragma statement. I will file a Temporal issue and link it here to track a fix for this.

@robholland
Copy link
Contributor Author

The SQLite pragma issue is now fixed: temporalio/temporal#3031

I will update this PR once the fix is in a release.

@robholland
Copy link
Contributor Author

This is failing builds due to: https://github.com/temporalio/ui-server/issues/80 which now seems to be considered as an error not a warning for the tests. Not sure what to do here :/

@jlegrone
Copy link
Collaborator

Hmm... the reproduction case in https://github.com/temporalio/ui-server/issues/80 doesn't panic. I'm not sure what's going on here exactly, do you mind rebasing now that #89 is merged?

@jlegrone jlegrone merged commit 5eaf107 into temporalio:main Jul 20, 2022
@robholland
Copy link
Contributor Author

Please revert this, the ui-server code isn't quite right and causes errors when using the UI.

@robholland
Copy link
Contributor Author

Tracking in temporalio/ui-server#188

jlegrone added a commit that referenced this pull request Jul 20, 2022
jlegrone added a commit that referenced this pull request Jul 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants