add support for multiple pragma statements and driver syntax #3031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense to me. This is not backward compatible though, previous style pragma settings will be silently ignored. Maybe we should check for the previous pragma style settings and throw an error asking them to update their config for a couple of versions? |
Instead of erroring, we can be backwards compatible. |
yiminc
reviewed
Jun 28, 2022
yiminc
reviewed
Jun 29, 2022
alexshtin
reviewed
Jun 30, 2022
Co-authored-by: Alex Shtin <alex@shtin.com>
alexshtin
approved these changes
Jun 30, 2022
Co-authored-by: Alex Shtin <alex@shtin.com>
jbreiding
added a commit
that referenced
this pull request
Jun 30, 2022
* add support for multiple pragma statements and driver syntax * Update common/persistence/sql/sqlplugin/sqlite/driver.go Co-authored-by: Alex Shtin <alex@shtin.com> * Update common/persistence/sql/sqlplugin/sqlite/plugin.go Co-authored-by: Alex Shtin <alex@shtin.com> Co-authored-by: Alex Shtin <alex@shtin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Change in how SQLite dsn is constructed to match upstream driver
Why?
Support multiple pragma statements
Change in upstream driver for file uri
How did you test it?
Updated unit tests
Local dev environment
Potential risks
None
Is hotfix candidate?
Yes