Skip to content
This repository has been archived by the owner on Dec 18, 2022. It is now read-only.

Removed code signing and notarization from Windows/macOS builds #54

Closed
wants to merge 1 commit into from
Closed

Removed code signing and notarization from Windows/macOS builds #54

wants to merge 1 commit into from

Conversation

n0toose
Copy link
Member

@n0toose n0toose commented Jul 6, 2021

The scripts in the scripts directory are flexible, in the sense that they
were also developed with scenarios, such as not being supplied any credentials
whatsoever. This means that we can just remove the environment variables
concerning code, and it should just work.

These changes have not been tested thoroughly yet, but are an improvement
given our situation. We hope to bring these back eventually, but they cost
money.

  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"

The scripts in the `scripts` directory are flexible, in the sense that they
were also developed with scenarios, such as not being supplied any credentials
whatsoever. This means that we can just remove the environment variables
concerning code, and it should just work.

These changes have not been tested thoroughly yet, but are an improvement
given our situation. We hope to bring these back eventually, but they cost
money.
@n0toose
Copy link
Member Author

n0toose commented Jul 6, 2021

This should resolve #9.

@Be-ing
Copy link
Contributor

Be-ing commented Jul 6, 2021

I recommend instead to modify the GitHub Actions workflow file to build when the environment variables are not specified. For example:
https://github.com/mixxxdj/mixxx/blob/main/.github/workflows/build.yml#L330

This allows for builds on the upstream repository to access the secrets for signing and notarization while also allowing GitHub Actions to run for pull requests from contributors' forks.

@n0toose
Copy link
Member Author

n0toose commented Jul 7, 2021

I recommend instead to modify the GitHub Actions workflow file to build when the environment variables are not specified. For example:
https://github.com/mixxxdj/mixxx/blob/main/.github/workflows/build.yml#L330

That's a good idea, but we do want to move away from GitHub Actions, eventually, and we also don't have a reasonable way to test this. Wouldn't it be best to do this later down the line?

@Be-ing
Copy link
Contributor

Be-ing commented Jul 9, 2021

I'm confused... is this needed at all? CI builds are succeeding on the master branch and on pull requests...

@n0toose n0toose closed this Jul 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants