Yet another round of minor bug fixes #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting is called merchantlogo not MerchantLogo, so it wasn't actually being used.
apps/registry/utils.py should ignore "not found" exceptions when importing files related to addon packages, but it should not silently ignore other exceptions, as this makes it difficult to troubleshoot problems with addon packages.
If user_agent happens to be unicode already, unicode() fails with "TypeError: decoding Unicode is not supported". Ignore this exception.
request.REQUEST is removed in Django 1.9 and does not work when running Django 1.8 under the Daphne web server. This commit replaces its use with request.POST/request.GET as appropriate, and also switches from the abandoned django-pagination library to the dj-pagination fork to fix the use of request.REQUEST in that library. (May want to consider switching from dj-pagination to the newer Pagination feature in Django itself.)
|
Excellent! Thank you @PaulSD ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.