-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add railtie #3
base: master
Are you sure you want to change the base?
Add railtie #3
Conversation
@@ -1,3 +1,5 @@ | |||
require 'railtie' if defined?(Rails) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change this file to 'hana/railtie'? It probably wouldn't be good to have a "railtie" file at the top level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's a good call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wait, this isn't my repo o_O. I'm sure @guillec will update it :)
Will do |
@guillec ! Any chance you can update this? 😉 |
@steveklabnik sorry :( yeah I will get do it this weekend. On Sun, Jun 8, 2014 at 11:01 PM, Steve Klabnik notifications@github.com
|
- If the gem is added to a rails project we register a mime type to respond to application/json-patch+json
@tenderlove @steveklabnik updated per your suggestion. |
Why can't this be in another gem? I don't think it's a good practice to include Rails stuff everywhere. For example, I plan to use this gem in a project. It's super simple, just one file, specific for the purpose of json-patch. With this PR, I'll have more code around which I won't use. I know it doesn't really affect the code if I don't require it, but it just feels messy to throw all code in a single gem. Maybe |
respond to application/json-patch+json
Based on conversation with @steveklabnik steveklabnik/merge_patch_test#2 (comment)