Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add signal proposal to reference and fix typo #49

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

dongsam
Copy link
Contributor

@dongsam dongsam commented Sep 30, 2021

Description

closes: #48

Tasks

  • Add Reference docs structure
  • Add first signal proposal
  • Fix typo in /README.md

References


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #49 (e0b310d) into master (d6677f3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   80.54%   80.54%           
=======================================
  Files          12       12           
  Lines         293      293           
=======================================
  Hits          236      236           
  Misses         42       42           
  Partials       15       15           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6677f3...e0b310d. Read the comment docs.

@dongsam
Copy link
Contributor Author

dongsam commented Sep 30, 2021

@kogisin I just copy docs from tendermint/farming#148 and fix farming words to budget and remove signal words because there would be not only signal proposal but also upgrade proposals on the proposals/ directory.
I missed that when reviewing tendermint/farming#148.

Copy link
Contributor

@jaybxyz jaybxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongsam dongsam merged commit 88b103b into tendermint:master Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: add Reference docs for signal proposals record
2 participants