Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: specify which ModuleName is used in demo #183

Merged
merged 1 commit into from
Oct 20, 2021
Merged

docs: specify which ModuleName is used in demo #183

merged 1 commit into from
Oct 20, 2021

Conversation

jaybxyz
Copy link
Contributor

@jaybxyz jaybxyz commented Oct 20, 2021 •
edited

Description

closes: #182

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@jaybxyz jaybxyz self-assigned this Oct 20, 2021
@dongsam
Copy link
Contributor

dongsam commented Oct 20, 2021

https://github.com/tendermint/budget/blob/b1fd56200d0b34708c9384ee725b8d83cb6649ca/docs/How-To/cli/README.md#L28 also needed to update

@jaybxyz
Copy link
Contributor Author

jaybxyz commented Oct 20, 2021

I'll create PR in the budget module for that.

@jaybxyz jaybxyz requested a review from dongsam October 20, 2021 07:45
@dongsam dongsam marked this pull request as ready for review October 20, 2021 07:48
@jaybxyz jaybxyz mentioned this pull request Oct 20, 2021
Merged
9 tasks
@jaybxyz jaybxyz merged commit bb1bda0 into tendermint:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongsam dongsam dongsam approved these changes

Assignees

@jaybxyz jaybxyz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: specify which ModuleName is used in demo
2 participants
@jaybxyz @dongsam