docs: add os checking for sed -i option #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* commit '305f2fb7da43f1050dd6aa591b43bbdadefa63bd': (23 commits) chore: bump Cosmos SDK version to 0.44.2 fix: emit `rewards_withdrawn` event (tendermint#166) chore: fix linter issue feat: refactor validating EpochAmount, EpochRatio feat: refactory ValidateStakingCoinTotalWeights fix: apply suggestions from review fix: terminate plan when deleting public plan proposal (tendermint#162) fix: change the logic to determine what the request is for chore: fix typo and use nil EpochRatio instead of zero chore: change error message test: update proposal handler tests fix: allow optional fields in UpdateRequestProposal fix: more strict validation and allow optional addrs fix: EpochAmount/EpochRatio fields can be both empty fix: allow empty plan name in UpdateRequestProposal fix!: forbid empty plan name and allow empty weights test: change expected error messages test: add tests for proposal validation test: add TestValidateStakingCoinTotalWeights fix: fix proposal validation logic ...
15 tasks
9 tasks
jaybxyz
added a commit
to jaybxyz/farming
that referenced
this pull request
Oct 27, 2021
* master: (22 commits) fix: use farmingPoolAcc and terminationAcc for consistency docs: add missing comments fix: last add_request_proposals docs: update renamed variables and remove mvp_legacy.md feat: rename public plan proposal requests feat: rename NewPublicPlanProposal to NewPublicPlanProposalHandler docs: update README.md fix: workflow target branch and description for main branch doc: fix to be broken links by renaming branch name move codeowners from contributing file to the CODEOWNERS file create CODEOWNERS file feat: generate proto files edit farming.proto docs: add os checking for sed -i option (tendermint#184) docs: specify which module is used for module name feat: bump budget to v0.1.1 (tendermint#177) docs: improve documentation for audit release (tendermint#178) fix: withdraw rewards only when staked amount changes (tendermint#180) fix: emit rewards_withdrawn only when positive amount is withdrawn docs: add helpful docs for audit (tendermint#176) ... # Conflicts: # x/farming/simulation/proposals.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses FreeBSD sed command (which is default for MacOS) but I have installed gnu
sedcommand (which is default for linux distros) and due to this reason the sed commands from the script can't be workso need to add simple os checking and using different
-ioptions for each osTasks
Ref
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Files changedin the Github PR explorerCodecov Reportin the comment section below once CI passes